Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix the wrong value of scaler active and the failure of paused value in Opentelemetry #5704

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Fix: fix the wrong value of scaler active and the failure of paused value in Opentelemetry #5704

merged 6 commits into from
Apr 23, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Apr 18, 2024 •
edited by zroubalik
Loading

fix the wrong value of scaler active and the failure of paused value in Opentelemetry

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes (#5705)

@SpiritZhou SpiritZhou requested a review from a team as a code owner April 18, 2024 08:39
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 18, 2024 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 19, 2024 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 19, 2024 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

zroubalik
zroubalik reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Could you please resolve conflicts? We merged some related stuff recently: #5687

Btw just checking, isn't there a similar problem with Prometheus?

@SpiritZhou
Update
8d8b760 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update ChangeLog
f805040 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Add log
5b7c0df 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
09f418d 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
01e2439 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Copy link
Contributor Author

Thanks for the fix. Could you please resolve conflicts? We merged some related stuff recently: #5687

Btw just checking, isn't there a similar problem with Prometheus?

No. As the lib of Prometheus doesn't use callback func to collect metric, it doesn't have the same issue as Opentelemetry.

@zroubalik
Copy link
Member

zroubalik commented Apr 22, 2024 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 23, 2024 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) April 23, 2024 06:49
@zroubalik zroubalik merged commit 9a00d1e into kedacore:main Apr 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiritZhou @zroubalik @JorTurFer