No need to list all secret in the namespace to find just one #5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
changed the title
|
/run-e2e internal |
zroubalik
reviewed
Apr 10, 2024
|
We are planning release on Thursday, any chance we can incorporate the feedback? |
|
changelog: d3427f8 |
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
force-pushed
the
more-love-4-rbac
branch
from
6f949a8 to
9f817b5
Compare
|
/run-e2e internal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to list all the secrets in the
kedaNamespaceand then iterate through them to find the one we are looking for. Instead, just get the one we are looking for -> this has an impact on the required RBAC since "list > get". If only get is required, we can restrict this even further using name allowlist for secrets.Relates to kedacore/charts#624