Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed in_progress detection on running jobs instead of just `queued… #5618

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

Eldarrin
Copy link
Contributor

@Eldarrin Eldarrin commented Mar 22, 2024

…` #5604

Modded the queue detection to count in progress jobs as well as just queued jobs to correctly represent total runner required instead of new runners required.

Checklist

Fixes #5604
Fixes #5605

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks (as always) @Eldarrin

@JorTurFer
Copy link
Member

JorTurFer commented Mar 25, 2024

/run-e2e github
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) March 25, 2024 22:12
@JorTurFer JorTurFer merged commit 1e1cfb1 into kedacore:main Mar 25, 2024
21 checks passed
@zroubalik
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants