Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Place the changelog entry in unreleased section #5519

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

JorTurFer
Copy link
Member

I merged this PR but the changelog was wrong and I didn't notice it

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5484

@JorTurFer JorTurFer requested a review from a team as a code owner February 17, 2024 14:43
@JorTurFer JorTurFer mentioned this pull request Feb 17, 2024
21 tasks
@JorTurFer
Copy link
Member Author

/skip-e2e

@JorTurFer JorTurFer merged commit 16e1ec6 into kedacore:main Feb 29, 2024
21 checks passed
@JorTurFer JorTurFer deleted the fix-changelog branch February 29, 2024 13:46
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Feb 29, 2024
@JorTurFer JorTurFer mentioned this pull request Feb 29, 2024
5 tasks
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Feb 29, 2024
JorTurFer added a commit that referenced this pull request Feb 29, 2024
* fix(gcp scalers): Restore previous time horizon to fix missing metrics and properly close the connecctions (#5452)

* fix(gcp scalers): Restore previous time horizon to fix missing metrics

Signed-off-by: Jorge Turrado <[email protected]>

* Close gcp client on scaler closing

Signed-off-by: Jorge Turrado <[email protected]>

* fix style

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix(prometheus-scaler): AWS signv4 parses region if provided (#5421)

Signed-off-by: Siva Guruvareddiar <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* Fixed the issue#5484 with inaccurate version label in release asset (#5518)

Signed-off-by: Vinod Kumar Nair <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix: Place the changelog entry in unreleased section (#5519)

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* prepare changelog

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Siva Guruvareddiar <[email protected]>
Signed-off-by: Vinod Kumar Nair <[email protected]>
Co-authored-by: Siva Guruvareddiar <[email protected]>
Co-authored-by: Vinod Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.kubernetes.io/version Label in *-core.yaml Release Asset Should Specify Version
3 participants