Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor scalers package and move ScalersConfig #5381

Merged
merged 1 commit into from
Jan 16, 2024
Merged

chore: refactor scalers package and move ScalersConfig #5381

merged 1 commit into from
Jan 16, 2024

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Jan 16, 2024 •
edited
Loading

Getting rid of circular dependency, that might happen when we try to create subpackages in pkg/scalers and use ScalerConfig there.

  • Moved scalers.ScalersConfig to new package: pkg/scalers/scalersconfig.ScalersConfig
  • Moved commong GCP related stuff to pkg/scalers/gcp
  • Moved common Kafka stuff to pkg/scalers/kafka
  • Fixed some linter validation problems

Checklist

Fixes #5379

@zroubalik zroubalik requested a review from a team as a code owner January 16, 2024 10:30
@zroubalik zroubalik requested a review from wozniakjan January 16, 2024 10:30
@tomkerkhove tomkerkhove marked this pull request as draft January 16, 2024 11:38
@tomkerkhove tomkerkhove marked this pull request as ready for review January 16, 2024 11:39
@zroubalik
Copy link
Member Author

zroubalik commented Jan 16, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) January 16, 2024 12:41
@zroubalik zroubalik disabled auto-merge January 16, 2024 14:55
@zroubalik
Copy link
Member Author

Failed tests:

2024-01-16T14:12:36.6720642Z 	Execution of tests/scalers/aws/aws_cloudwatch_pod_identity_eks/aws_cloudwatch_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6723578Z 	Execution of tests/scalers/aws/aws_dynamodb_pod_identity_eks/aws_dynamodb_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6726082Z 	Execution of tests/internals/events/events_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6728669Z 	Execution of tests/scalers/aws/aws_kinesis_stream_pod_identity_eks/aws_kinesis_stream_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6731595Z 	Execution of tests/scalers/redis/redis_sentinel_streams_lag/redis_sentinel_streams_lag_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6734431Z 	Execution of tests/scalers/aws/aws_sqs_queue_pod_identity_eks/aws_sqs_queue_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6737811Z 	Execution of tests/scalers/redis/redis_sentinel_streams_pending_entries/redis_sentinel_streams_pending_entries_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6746359Z 	Execution of tests/scalers/redis/redis_sentinel_streams_length/redis_sentinel_streams_length_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6749425Z 	Execution of tests/scalers/aws/aws_dynamodb_streams_pod_identity_eks/aws_dynamodb_streams_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6752531Z 	Execution of tests/scalers/redis/redis_sentinel_lists/redis_sentinel_lists_test.go, has failed after "three" attempts

@zroubalik
Copy link
Member Author

zroubalik commented Jan 16, 2024 •
edited by github-actions bot
Loading

/run-e2e events|aws|redis
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented Jan 16, 2024 •
edited
Loading

Failed tests:

2024-01-16T14:12:36.6720642Z 	Execution of tests/scalers/aws/aws_cloudwatch_pod_identity_eks/aws_cloudwatch_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6723578Z 	Execution of tests/scalers/aws/aws_dynamodb_pod_identity_eks/aws_dynamodb_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6726082Z 	Execution of tests/internals/events/events_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6728669Z 	Execution of tests/scalers/aws/aws_kinesis_stream_pod_identity_eks/aws_kinesis_stream_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6731595Z 	Execution of tests/scalers/redis/redis_sentinel_streams_lag/redis_sentinel_streams_lag_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6734431Z 	Execution of tests/scalers/aws/aws_sqs_queue_pod_identity_eks/aws_sqs_queue_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6737811Z 	Execution of tests/scalers/redis/redis_sentinel_streams_pending_entries/redis_sentinel_streams_pending_entries_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6746359Z 	Execution of tests/scalers/redis/redis_sentinel_streams_length/redis_sentinel_streams_length_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6749425Z 	Execution of tests/scalers/aws/aws_dynamodb_streams_pod_identity_eks/aws_dynamodb_streams_pod_identity_eks_test.go, has failed after "three" attempts
2024-01-16T14:12:36.6752531Z 	Execution of tests/scalers/redis/redis_sentinel_lists/redis_sentinel_lists_test.go, has failed after "three" attempts

Seems like it fails on main too, not related to this change:
https://github.com/kedacore/keda/actions/runs/7541031066/job/20527087612

@tomkerkhove tomkerkhove enabled auto-merge (squash) January 16, 2024 16:08
@tomkerkhove tomkerkhove mentioned this pull request Jan 16, 2024
Merged
7 tasks
@zroubalik zroubalik disabled auto-merge January 16, 2024 16:31
@zroubalik zroubalik merged commit 56385f1 into kedacore:main Jan 16, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan Awaiting requested review from wozniakjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor scalers package
2 participants
@zroubalik @JorTurFer