gcp_pubsub: fix scaled object default value (#5093) #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
jimgus
force-pushed
the
fix_gcp_pubsub_defaults
branch
from
02a54a9 to
5f880bc
Compare
|
/run-e2e gcp |
JorTurFer
approved these changes
Nov 1, 2023
Signed-off-by: Jim Gustavsson <[email protected]>
jimgus
force-pushed
the
fix_gcp_pubsub_defaults
branch
from
83b28e8 to
54f8f1d
Compare
|
/run-e2e gcp |
auto-merge was automatically disabled
November 1, 2023 14:33
Head branch was pushed to by a user without write access
|
Last commit has broken the DCO check. You need to sign it 🙏 |
Signed-off-by: Jim Gustavsson <[email protected]>
jimgus
force-pushed
the
fix_gcp_pubsub_defaults
branch
from
bf4ec4d to
63bbc08
Compare
|
/run-e2e gcp |
|
/run-e2e gcp |
yoongon
pushed a commit
to yoongon/keda
that referenced
this pull request
Nov 24, 2023
…#5099) Signed-off-by: Yoon Park <[email protected]>
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
…#5099) Signed-off-by: anton.lysina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that the default value of
valueis used when default value ofmodeis used for GCP pubsub scaler.Checklist
Fixes #5093
Relates to #