Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show only logs with a severity level of ERROR or higher in the stderr #4944

Closed
wants to merge 9 commits into from

Conversation

Adarsh-verma-14
Copy link
Contributor

Signed-off-by: Adarsh-verma-14 [email protected]

In the logs of keda-metrics-apiserver, show only printing errors, but errors should go to stderr.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4049

@Adarsh-verma-14 Adarsh-verma-14 requested a review from a team as a code owner September 4, 2023 07:30
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

Signed-off-by: Adarsh Verma <[email protected]>
CHANGELOG.md Outdated
@@ -91,6 +91,7 @@ New deprecation(s):
- **GitHub Runner Scaler**: Fix explicit repo check 404 to skip not crash ([#4790](https://github.com/kedacore/keda/issues/4790))
- **GitHub Runner Scaler**: Fix rate checking on GHEC when HTTP 200 ([#4786](https://github.com/kedacore/keda/issues/4786))
- **Pulsar Scaler**: Fix `msgBacklogThreshold` field being named wrongly as `msgBacklog` ([#4681](https://github.com/kedacore/keda/issues/4681))
- **General**: Add one deployment arg in keda-metrics-apiserver for only printing errors, but errors should go to stderr ([#4049](https://github.com/kedacore/keda/issues/4049))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this up to Unreleased section, to ### Other subsection? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @zroubalik , actually there are some problem with my side and branches during update, so I am closing this PR and will again raised regarding same things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for this inconvenience .

JorTurFer and others added 7 commits September 6, 2023 20:43
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ring (kedacore#4584)

* fix RabbitMQ Scaler, allow subpaths along with vhost in connection string (kedacore#4584)

Signed-off-by: Roman Bielyi <[email protected]>

* Fix CHANGELOG.md, remove redundant/wrong pieces that were made during rebase, this fix is aimed to resolve failed workflow's Static Check (validate-changelog) test

Signed-off-by: Roman Bielyi <[email protected]>

---------

Signed-off-by: Roman Bielyi <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Adarsh-verma-14 <[email protected]>
@Adarsh-verma-14 Adarsh-verma-14 deleted the new-arg branch September 6, 2023 16:47
@Adarsh-verma-14
Copy link
Contributor Author

I have closed this PR and also raised a new PR(#4952 ) for the same issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics-apiserver json logs
6 participants