Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #4902

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix typo #4902

merged 1 commit into from
Aug 24, 2023

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Aug 23, 2023

s/deployment/statefulset in pkg/scaling/resolver/scaling_resolver.go for the StatefulSet scaling resolver error message.

Fixed a typo in the error message for the StatefulSet scaling resolver.

Checklist

I didn't open an issue for this since it seems extremely minor. I can go back and do that if necessary.

@drmorr0 drmorr0 requested a review from a team as a code owner August 23, 2023 18:21
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

@drmorr0 drmorr0 force-pushed the drmorr/fix-typo branch 2 times, most recently from 2f32dbe to 1948f37 Compare August 23, 2023 18:47
@drmorr0
Copy link
Contributor Author

drmorr0 commented Aug 23, 2023

Hmmm. It doesn't seem like the failing test has anything to do with my change? Anything I can do to get it to pass?

@SpiritZhou
Copy link
Contributor

I am not quite sure why this test is failed but retry it and it will be passed.

CHANGELOG.md Outdated Show resolved Hide resolved
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go`
for the StatefulSet scaling resolver error message.

Signed-off-by: David Morrison <[email protected]>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💪

@JorTurFer JorTurFer enabled auto-merge (squash) August 24, 2023 15:49
@JorTurFer JorTurFer enabled auto-merge (squash) August 24, 2023 15:49
@JorTurFer
Copy link
Member

/skip-e2e

@JorTurFer JorTurFer merged commit ef3a579 into kedacore:main Aug 24, 2023
19 checks passed
yoongon pushed a commit to yoongon/keda that referenced this pull request Aug 26, 2023
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go`
for the StatefulSet scaling resolver error message.

Signed-off-by: David Morrison <[email protected]>
Signed-off-by: Yoon Park <[email protected]>
novicr pushed a commit to novicr/keda that referenced this pull request Aug 26, 2023
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go`
for the StatefulSet scaling resolver error message.

Signed-off-by: David Morrison <[email protected]>
Adarsh-verma-14 pushed a commit to Adarsh-verma-14/keda that referenced this pull request Sep 4, 2023
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go`
for the StatefulSet scaling resolver error message.

Signed-off-by: David Morrison <[email protected]>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go`
for the StatefulSet scaling resolver error message.

Signed-off-by: David Morrison <[email protected]>
Signed-off-by: anton.lysina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants