Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce GitHub App authentication for GitHub Scaler #4708

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Introduce GitHub App authentication for GitHub Scaler #4708

merged 10 commits into from
Jun 21, 2023

Conversation

Eldarrin
Copy link
Contributor

@Eldarrin Eldarrin commented Jun 19, 2023 •
edited by zroubalik
Loading

Implemented Authentication with GitHub App rather than PAT token

Checklist

Fixes #4651

Relates to kedacore/keda-docs#1159
Relates to kedacore/test-tools#127

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@Eldarrin Eldarrin mentioned this pull request Jun 19, 2023
Merged
1 task
@Eldarrin Eldarrin changed the title GitHub app Introduce GitHub App authentication for Keda Scaler Jun 19, 2023
@Eldarrin Eldarrin marked this pull request as ready for review June 19, 2023 12:35
@Eldarrin Eldarrin requested a review from a team as a code owner June 19, 2023 12:35
@JorTurFer
Copy link
Member

JorTurFer commented Jun 19, 2023 •
edited by github-actions bot
Loading

/run-e2e github
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Jun 19, 2023 •
edited by github-actions bot
Loading

/run-e2e github
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Jun 20, 2023 •
edited by github-actions bot
Loading

/run-e2e github
Update: You can check the progress here

@Eldarrin
Copy link
Contributor Author

I noticed you ran the e2e 3 times, anything I should put in the docs as a note?

@JorTurFer
Copy link
Member

anything I should put in the docs as a note?

No, it was written indeed, the 1s try I used client secret instead of private key, the second one I used the private key in plain text, and the last one I read the documentation you did, and I saw that I should have set the private key in base64...

The problem has been in the keyboard-chair interface xD

@Eldarrin
Copy link
Contributor Author

don't merge it yet, just thought of something I need to check

@JorTurFer
Copy link
Member

JorTurFer commented Jun 20, 2023 •
edited
Loading

don't merge it yet, just thought of something I need to check

sure!, remove the WIP from the title once you think is ready

@JorTurFer JorTurFer changed the title Introduce GitHub App authentication for Keda Scaler WIP - Introduce GitHub App authentication for Keda Scaler Jun 20, 2023
@Eldarrin
Copy link
Contributor Author

Its okay, it only relates to test not the scaler. On the e2e we provide pat in clear and use the e2e to b64 it. for the secret it needs to be b64.

@Eldarrin Eldarrin changed the title WIP - Introduce GitHub App authentication for Keda Scaler Introduce GitHub App authentication for Keda Scaler Jun 20, 2023
JorTurFer
JorTurFer reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one small nit inline

pkg/scalers/github_runner_scaler.go Outdated Show resolved Hide resolved
zroubalik
zroubalik reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks for the contribution.

pkg/scalers/github_runner_scaler.go Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

zroubalik commented Jun 21, 2023 •
edited by github-actions bot
Loading

/run-e2e github
Update: You can check the progress here

@zroubalik zroubalik changed the title Introduce GitHub App authentication for Keda Scaler Introduce GitHub App authentication for GitHub Scaler Jun 21, 2023
zroubalik
zroubalik reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eldarrin could you please fix the conflict? 🙇‍♂️

@Eldarrin
Copy link
Contributor Author

No idea why that is failing, doesn't look like my code

zroubalik
zroubalik approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit d5ef935 into kedacore:main Jun 21, 2023
@Eldarrin Eldarrin deleted the github-app branch June 21, 2023 12:46
@piroinno
Copy link

Will you be cutting a new release soon?

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jun 30, 2023
@Eldarrin @SpiritZhou
Introduce GitHub App authentication for GitHub Scaler (kedacore#4708)
478b39d 
Signed-off-by: Eldarrin <[email protected]>
Signed-off-by: Andy Ward <[email protected]>
Signed-off-by: Eldarrin <[email protected]>
Co-authored-by: Andy Ward <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harden GitHub Runner Spec
4 participants
@Eldarrin @JorTurFer @zroubalik @piroinno