Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add OAuth extensions for kafka scaler #4486

Merged
merged 1 commit into from
May 18, 2023
Merged

feat: Add OAuth extensions for kafka scaler #4486

merged 1 commit into from
May 18, 2023

Conversation

qvalentin
Copy link
Contributor

@qvalentin qvalentin commented Apr 28, 2023 •
edited
Loading

Add support for OAuth extensions for Kafka Scaler. This is required for using OAuth with a Confluent Kafka Server (KIP-342).

Checklist

Fixes #4544

Relates to kedacore/keda-docs#1121

@qvalentin qvalentin requested a review from a team as a code owner April 28, 2023 08:57
@qvalentin qvalentin mentioned this pull request Apr 28, 2023
Merged
1 task
@qvalentin qvalentin force-pushed the feat-kafka-oauth-extension branch from be322f0 to 7d75bc8 Compare May 2, 2023 08:45
@qvalentin qvalentin force-pushed the feat-kafka-oauth-extension branch 2 times, most recently from 548da56 to 128a561 Compare May 3, 2023 06:48
@qvalentin
Copy link
Contributor Author

Whats the status on this?

@zroubalik
Copy link
Member

Whats the status on this?

I have been away for some time, will check this later this week. Thanks!

zroubalik
zroubalik reviewed May 17, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just please update the Changelog & create an issue

CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

zroubalik commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e kafka
Update: You can check the progress here

zroubalik
zroubalik reviewed May 17, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please also rebase your PR?

@qvalentin qvalentin mentioned this pull request May 17, 2023
Closed
@qvalentin qvalentin force-pushed the feat-kafka-oauth-extension branch 2 times, most recently from 6a0490c to 9a52bbe Compare May 17, 2023 15:05
@zroubalik
Copy link
Member

zroubalik commented May 18, 2023 •
edited by github-actions bot
Loading

/run-e2e kafka
Update: You can check the progress here

zroubalik
zroubalik approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@zroubalik zroubalik merged commit 2c77385 into kedacore:main May 18, 2023
@qvalentin
Copy link
Contributor Author

Thanks a lot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OAuth extensions for kafka scaler
3 participants
@qvalentin @zroubalik @JorTurFer