Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Default metric providers #4473

Merged
merged 7 commits into from
May 18, 2023
Merged

feat: use Default metric providers #4473

merged 7 commits into from
May 18, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Apr 24, 2023 •
edited
Loading

Checklist

Fixes #

Relates to kubernetes-sigs/custom-metrics-apiserver#151

@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 24, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 26, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer force-pushed the poc-single-metric branch from 575ec5c to f991f68 Compare May 9, 2023 19:23
@JorTurFer JorTurFer changed the title WIP - feat: use Default metric providers feat: use Default metric providers May 9, 2023
@JorTurFer JorTurFer marked this pull request as ready for review May 9, 2023 19:25
@JorTurFer JorTurFer requested a review from a team as a code owner May 9, 2023 19:25
@JorTurFer
Copy link
Member Author

JorTurFer commented May 9, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer requested a review from zroubalik May 9, 2023 19:54
@JorTurFer JorTurFer mentioned this pull request May 9, 2023
Merged
3 tasks
@tomkerkhove
Copy link
Member

I'll need to defer this to @zroubalik - Sorry :(

@JorTurFer
Copy link
Member Author

JorTurFer commented May 10, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik mentioned this pull request May 15, 2023
Closed
JorTurFer added 3 commits May 15, 2023 15:13
@JorTurFer
feat: use Default metric providers
8c538f6 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
add missing changes
ca871cb 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
update generated files
30387aa 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer force-pushed the poc-single-metric branch from 9d0b0af to 30387aa Compare May 15, 2023 13:13
@JorTurFer
remove unsued code
0feabea 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 15, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
remove unused code
293e5ad 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

JorTurFer added 2 commits May 17, 2023 15:43
@JorTurFer
remove unused code
3dc0d41 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
remove more unused code
6b2b552 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented May 17, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik merged commit 8c9dd7f into kedacore:main May 18, 2023
@JorTurFer JorTurFer deleted the poc-single-metric branch May 18, 2023 07:56
@JorTurFer JorTurFer mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorTurFer @tomkerkhove @zroubalik @dgrisonnet