-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Provide documentation for keda.sh #433
Conversation
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Provide first rough documentation site for KEDA.sh
Signed-off-by: Tom Kerkhove <[email protected]>
PR ExperienceThe PR experience will look like this: This gives you a preview URL to see the changes: If @jeffhollan would be up for it, we could add a banner at the top saying it's just a preview not the official stuff like this: Preview BannerThis is just for @jeffhollan but you can go here: And use this snippet: Preview Content snippet
|
It looks great to me :) Thank you very much @tomkerkhove for the awesome stuff! @jeffhollan I wonder if it'll be better to move this to a |
Yeah I’m fine if we break it out. My only thinking of the benefit of having in one spot is that when people open up a PR for something like a scaler we can have them have the docs as part of the same PR. But we can obviously enforce that across repos too - just something we’ll need to let people know to link related PRs for docs / code. |
Yeah @tomkerkhove just playing with Netlify. I wonder if we move these commits over to kedacore/keda-docs and will just include in the contributor guide you need to update docs as well. Let me create |
@tomkerkhove I created the repo and gave you write permissions. I also hooked up Netlify for that repo. |
I agree with Jeff on this. If it's a seperate repo it's harder to have good docs.
I use the approach of the PR for Promitor.io and when somebody creates a PR it includes feature, tests and docs - Good to go!
Here there is more friction and a higher contribution barrier, or docs will just be ignored
|
Example of the contribution flow: tomkerkhove/promitor#766 PR validates build, tests and generates preview of docs. |
Provide documentation on all scalers
At first I was thinking docs was just a nested folder of markdown files, but there’s a lot of additional files here and folks may make changes to site without repo. I think my thinking now is we have a separate repo for the site : docs and just enforce folks link PRs for docs on new scalers. |
Do you mean the files for the template or? |
I just mean files for the docs plus files for the website. It feels like a lot of changed files were pushing in when I think we can still enforce right behavior but not have a JavaScript single page app nested inside a Kubernetes deployment. This PR has like 1k+ files |
That's correct and is due to the template which should be a one off thing which I think is fine, but if you guys want it seperate that's fine for me - Just very doubtful that we'll have parity in our docs 😁 |
So I'll move it then or? |
Let’s move for now and I may even setup a GitHub action that labels until docs are linked with some hashtag or something. If ends up drifting over time we can always move back. keda.sh alreadh hooked up To the docs repo and you have merge rights so let me know if you can pop over there. I can too today with this branch. Let me know |
Ok, I'll commit the template to new repo and open PR for content review!
|
Boilerplate doc PR has been sent with mainly basic structure and template, more details to follow in follow-up PR. |
@tomkerkhove we can close this, right? |
Provide documentation for
keda.sh
based on Hugo &syna
template. The template is included via a sub-module in Git based on the official Hugo guidance which is blowing up the PR, sorry for that.Once Netlify is setup, every PR will include a preview version of the docs.
syna
themedocs\netlify.toml
)Follow-up:
keda.sh
to route to Netlify (@jeffhollan)