Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Provide documentation for keda.sh #433

Closed
wants to merge 25 commits into from

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Nov 7, 2019

Provide documentation for keda.sh based on Hugo & syna template. The template is included via a sub-module in Git based on the official Hugo guidance which is blowing up the PR, sorry for that.

Once Netlify is setup, every PR will include a preview version of the docs.

  • Provide documentation skeleton with syna theme
  • Provide landing page
  • Provide scaler overview
  • Provide getting started
  • Provide deployment guidance
  • Migrate all scalers
    • Samples
    • Docs
  • Setup doc hosting on Netlify
    • Configure Netlify app on repo (@jeffhollan)
    • Create Netlify site (@jeffhollan)
    • Configure deployment (docs\netlify.toml)
  • Provide documentation
    • How to run docs locally
    • How to write docs for new scalers

Follow-up:

  • Create issue for docs on Operator deployment
  • Remove the wiki
  • Setup DNS for keda.sh to route to Netlify (@jeffhollan)

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Nov 7, 2019

PR Experience

The PR experience will look like this:
image

This gives you a preview URL to see the changes:
image

If @jeffhollan would be up for it, we could add a banner at the top saying it's just a preview not the official stuff like this:
image

Preview Banner

This is just for @jeffhollan but you can go here:
image

And use this snippet:

Preview Content snippet
<style>
.alert {
    padding: 20px;
    background-color: #2196F3;
    color: white;
}

.closebtn {
    margin-left: 15px;
    color: white;
    font-weight: bold;
    float: right;
    font-size: 22px;
    line-height: 20px;
    cursor: pointer;
    transition: 0.3s;
}

.closebtn:hover {
    color: black;
}
</style>

<div class="alert">
This is a preview.
</div>

@ahmelsayed
Copy link
Contributor

It looks great to me :) Thank you very much @tomkerkhove for the awesome stuff!

@jeffhollan I wonder if it'll be better to move this to a keda-docs or kedacore-docs repo

@jeffhollan
Copy link
Member

Yeah I’m fine if we break it out. My only thinking of the benefit of having in one spot is that when people open up a PR for something like a scaler we can have them have the docs as part of the same PR. But we can obviously enforce that across repos too - just something we’ll need to let people know to link related PRs for docs / code.

@jeffhollan
Copy link
Member

Yeah @tomkerkhove just playing with Netlify. I wonder if we move these commits over to kedacore/keda-docs and will just include in the contributor guide you need to update docs as well. Let me create

@jeffhollan
Copy link
Member

@tomkerkhove I created the repo and gave you write permissions. I also hooked up Netlify for that repo.

https://github.com/kedacore/keda-docs

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Nov 9, 2019 via email

@tomkerkhove
Copy link
Member Author

Example of the contribution flow: tomkerkhove/promitor#766

PR validates build, tests and generates preview of docs.

Provide documentation on all scalers
@jeffhollan
Copy link
Member

At first I was thinking docs was just a nested folder of markdown files, but there’s a lot of additional files here and folks may make changes to site without repo. I think my thinking now is we have a separate repo for the site : docs and just enforce folks link PRs for docs on new scalers.

@tomkerkhove
Copy link
Member Author

At first I was thinking docs was just a nested folder of markdown files, but there’s a lot of additional files here and folks may make changes to site without repo.

Do you mean the files for the template or?

@jeffhollan
Copy link
Member

I just mean files for the docs plus files for the website. It feels like a lot of changed files were pushing in when I think we can still enforce right behavior but not have a JavaScript single page app nested inside a Kubernetes deployment. This PR has like 1k+ files

@tomkerkhove
Copy link
Member Author

That's correct and is due to the template which should be a one off thing which I think is fine, but if you guys want it seperate that's fine for me - Just very doubtful that we'll have parity in our docs 😁

@tomkerkhove
Copy link
Member Author

So I'll move it then or?

@jeffhollan
Copy link
Member

Let’s move for now and I may even setup a GitHub action that labels until docs are linked with some hashtag or something. If ends up drifting over time we can always move back. keda.sh alreadh hooked up To the docs repo and you have merge rights so let me know if you can pop over there. I can too today with this branch. Let me know

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Nov 11, 2019 via email

@tomkerkhove
Copy link
Member Author

Boilerplate doc PR has been sent with mainly basic structure and template, more details to follow in follow-up PR.

kedacore/keda-docs#2

@ahmelsayed
Copy link
Contributor

@tomkerkhove we can close this, right?

@tomkerkhove tomkerkhove deleted the master branch November 13, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants