Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rabbitmq): Parse vhost correctly if it's provided in the host url #3604

Merged
merged 1 commit into from
Sep 1, 2022
Merged

fix(rabbitmq): Parse vhost correctly if it's provided in the host url #3604

merged 1 commit into from
Sep 1, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Aug 26, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado [email protected]

After this PR, the parsing of the vHost from the url changed. With this PR we restore that behaviour and add 2 extra e2e test to ensure that these changes works with and without vHost on amqp and http

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3602

@JorTurFer JorTurFer requested a review from a team as a code owner August 26, 2022 12:53
@JorTurFer JorTurFer force-pushed the fix-rabbit branch 2 times, most recently from f463238 to 26ec5bc Compare August 26, 2022 13:02
@JorTurFer
Copy link
Member Author

JorTurFer commented Aug 26, 2022 •
edited by github-actions bot
Loading

/run-e2e rabbit*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 1, 2022 •
edited by github-actions bot
Loading

/run-e2e rabbit*
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) September 1, 2022 09:26
@JorTurFer JorTurFer merged commit f5b7234 into kedacore:main Sep 1, 2022
@JorTurFer JorTurFer deleted the fix-rabbit branch September 1, 2022 09:53
andyatwork pushed a commit to andyatwork/keda that referenced this pull request Oct 31, 2022
@JorTurFer @andyatwork
fix(rabbitmq): Parse vhost correctly if it's provided in the host url (…
552d429 
…kedacore#3604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RabbitMQ Scaler doesn't parse vhost correctly if provided in the host url
2 participants
@JorTurFer @zroubalik