automation: Use reusable workflows to avoid duplications #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
changed the title
JorTurFer
force-pushed
the
reusable-workflows
branch
from
6dcf02f to
4ea800d
Compare
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
force-pushed
the
reusable-workflows
branch
from
4ea800d to
f93fc6f
Compare
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
force-pushed
the
reusable-workflows
branch
8 times, most recently
from
d17dcdd to
9085ddb
Compare
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
force-pushed
the
reusable-workflows
branch
2 times, most recently
from
074cb63 to
2b58a37
Compare
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
force-pushed
the
reusable-workflows
branch
from
cad058f to
8815e84
Compare
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
changed the title
|
Important @kedacore/keda-core-contributors , DON'T MERGE this PR, I have to modify this line https://github.com/kedacore/keda/pull/3593/files#diff-04af3c9c96028eebf4fa93d5c67e1fa08255fb7a3682f912ccd5bea1dff5ccd4R213 to point |
Signed-off-by: Jorge Turrado <[email protected]>
|
kind team will do a release soon, so I'll wait to include the node v1.25 too |
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
|
I need to merge this PR because it's blocking me for other things, once kind releases the new node we can add it in another PR |
andyatwork
pushed a commit
to andyatwork/keda
that referenced
this pull request
Oct 31, 2022
* move smoke test to resuable workflows for ARM and multi versions Signed-off-by: Jorge Turrado <[email protected]> * fix styles Signed-off-by: Jorge Turrado <[email protected]> * add needed permission to script Signed-off-by: Jorge Turrado <[email protected]> * dummy Signed-off-by: Jorge Turrado <[email protected]> * undo dummy changes Signed-off-by: Jorge Turrado <[email protected]> * add rw to trivy Signed-off-by: Jorge Turrado <[email protected]> * use main for rw Signed-off-by: Jorge Turrado <[email protected]> * add rw for e2e test on main Signed-off-by: Jorge Turrado <[email protected]> * undo dummy change Signed-off-by: Jorge Turrado <[email protected]> * use current branch on PR Signed-off-by: Jorge Turrado <[email protected]> * update changelog Signed-off-by: Jorge Turrado <[email protected]> * remove whitespace Signed-off-by: Jorge Turrado <[email protected]> * rename templates Signed-off-by: Jorge Turrado <[email protected]> * Update trivy to set severity Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado [email protected]
This PR introduces GitHub reusable workflows to reduce duplicated code. As GitHub doesn't support placing reusable workflows everywhere, I placed them in
workflowsfolder (the only place where they can be inside the repo) with the prefixrwto distinguish them from regular workflows. If we want to move to another place, we can move them into a shared repo in the org (I don't like it)The summary of the changes is:
main-build.ymlandnightly-e2e.ymlmain-build.ymlandnightly-e2e.ymlmain-build.yml,nightly-e2e.ymlandpr-validation.ymlubuntu-latestand every supported k8s version.Checklist
Fixes #2569