Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leader Election Lease Options #3430

Merged
merged 8 commits into from
Aug 3, 2022
Merged

Add Leader Election Lease Options #3430

merged 8 commits into from
Aug 3, 2022

Conversation

wsugarman
Copy link
Contributor

@wsugarman wsugarman commented Jul 27, 2022

Add new options for configuring the leader election lease, including:

  • KEDA_OPERATOR_LEADER_ELECTION_LEASE_DURATION
  • KEDA_OPERATOR_LEADER_ELECTION_RENEW_DEADLINE
  • KEDA_OPERATOR_LEADER_ELECTION_RETRY_PERIOD
  • KEDA_METRICS_LEADER_ELECTION_LEASE_DURATION
  • KEDA_METRICS_LEADER_ELECTION_RENEW_DEADLINE
  • KEDA_METRICS_LEADER_ELECTION_RETRY_PERIOD

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo)
    • Skipped because these values are new environment variables that may be configured through the existing env element
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #2836
Relates to kedacore/keda-docs#842

Signed-off-by: Will Sugarman <[email protected]>
Signed-off-by: Will Sugarman <[email protected]>
@wsugarman wsugarman marked this pull request as ready for review July 27, 2022 02:04
@wsugarman wsugarman requested a review from a team as a code owner July 27, 2022 02:04
main.go Outdated Show resolved Hide resolved
@wsugarman
Copy link
Contributor Author

I am unsure if this should result in new documentation

@zroubalik
Copy link
Member

I am unsure if this should result in new documentation

Yeah, we should cover this in this section of docs: https://keda.sh/docs/2.8/operate/cluster/

Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Will Sugarman <[email protected]>
Signed-off-by: Will Sugarman <[email protected]>
@wsugarman
Copy link
Contributor Author

Taking another look, perhaps there are too many options and it's better to simply share the same values for both the operator and metrics server?

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's a lot of new values, but I think that it is okay to keep it like this :)

@zroubalik
Copy link
Member

zroubalik commented Aug 2, 2022

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik self-assigned this Aug 2, 2022
Signed-off-by: Will Sugarman <[email protected]>
Signed-off-by: Will Sugarman <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Aug 3, 2022

/run-e2e cron*
Update: You can check the progress here

@zroubalik zroubalik merged commit cdcbdbf into kedacore:main Aug 3, 2022
@wsugarman
Copy link
Contributor Author

@zroubalik Thank you for your help!

@wsugarman wsugarman deleted the users/wsugarman/lease-options branch August 3, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants