Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promethues_scaler: add url in error information #3406

Closed
wants to merge 2 commits into from

Conversation

surki
Copy link
Contributor

@surki surki commented Jul 20, 2022

Without the query its hard to debug which query is causing the error when there are hundreds of scalers.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

@surki surki requested a review from a team as a code owner July 20, 2022 10:55
Without the query its hard to debug which query is causing the error when
there are hundreds of scalers.

Signed-off-by: Suresh Kumar <[email protected]>
Signed-off-by: Suresh Kumar Ponnusamy <[email protected]>
@surki surki changed the title promethues_scler: add url in error information promethues_scaler: add url in error information Jul 20, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Suresh Kumar Ponnusamy <[email protected]>
@zroubalik
Copy link
Member

I wonder whether it is not a privacy problem to expose the full url in the logs. Let me get back to you next week.

@tomkerkhove
Copy link
Member

I wonder whether it is not a privacy problem to expose the full url in the logs. Let me get back to you next week.

I don't think it hurts; if you have access to the logs then it's fair to say you are a cluster admin; no? I do get the concern though.

@JorTurFer
Copy link
Member

JorTurFer commented Jul 21, 2022

I don't think it hurts; if you have access to the logs then it's fair to say you are a cluster admin; no? I do get the concern though.

I wouldn't assume that people with access to logs are admins... ie, In Docplanner all devs have access to all the logs in the clusters but not to secrets or configs. I think that the url itself is not a secret (at this point in code, that variable contains only the url, not the url with user and password) but maybe I'm wrong

@zroubalik
Copy link
Member

Would following feature help?
#3419

@surki
Copy link
Contributor Author

surki commented Jul 25, 2022

Would following feature help? #3419

yes, that should be good enough (as long as full name is there, namespace + name)

I will close this, thanks.

@surki surki closed this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants