Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for permission segregation when using Azure AD Pod & Workload Identity. #3216

Merged
merged 11 commits into from
Jun 27, 2022
Merged

Support for permission segregation when using Azure AD Pod & Workload Identity. #3216

merged 11 commits into from
Jun 27, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Jun 21, 2022 •
edited by tomkerkhove
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #2656
Relates to kedacore/keda-docs#790

@v-shenoy v-shenoy requested a review from a team as a code owner June 21, 2022 20:59
@v-shenoy v-shenoy mentioned this pull request Jun 21, 2022
Merged
1 task
tomkerkhove
tomkerkhove reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Go expert but think this looks OK.

I didn't see (m)any tests using separate identities though or did I look over them?

apis/keda/v1alpha1/triggerauthentication_types.go Outdated Show resolved Hide resolved
pkg/scalers/azure_servicebus_scaler_test.go Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

tomkerkhove commented Jun 22, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

JorTurFer
JorTurFer reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Apart from @tomkerkhove comments, I left another inline

pkg/scalers/azure/azure_aad_workload_identity.go Show resolved Hide resolved
@v-shenoy v-shenoy mentioned this pull request Jun 22, 2022
Closed
@zroubalik
Copy link
Member

zroubalik commented Jun 23, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

/run-e2e azure* Update: You can check the progress here

Some environment variables and resources are required. #3262

@v-shenoy v-shenoy force-pushed the permission-segregation branch 2 times, most recently from b49d44c to e3ef2a8 Compare June 24, 2022 13:26
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 24, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@tomkerkhove
Copy link
Member

tomkerkhove commented Jun 24, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*

Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 24, 2022 •
edited by github-actions bot
Loading

/run-e2e workload*
Update: You can check the progress here

JorTurFer
JorTurFer reviewed Jun 26, 2022
View reviewed changes
tests/helper/helper.go Outdated Show resolved Hide resolved
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e workload*
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e user_assigned*
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e user_assigned*
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e user_assigned*
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

/run-e2e azure*

Final sanity check.

@v-shenoy
Copy link
Contributor Author

/run-e2e azure* Update: You can check the progress here

The app insights test is failing, but I think it's unrelated to the changes because this sometimes fails randomly in main-build as well. See here.

@tomkerkhove @JorTurFer

@tomkerkhove
Copy link
Member

tomkerkhove commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@v-shenoy
Fix unit tests.
72b0d6c 
Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy
Address PR feedback.
f35211b 
Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy
Add E2E tests.
862d514 
Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy
Minor refactor.
d87b469 
Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy
Refactor tests.
e34e056 
Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy
Fix helper method.
e2b7221 
Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy
Fix stupid mistake.
d516b98 
Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy
Copy link
Contributor Author

Fixed the conflicts in CHANGELOG.

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

Anything else to add here @JorTurFer ? Only thing changed since last e2e test run was fixing a merge conflict in the changelog.

@JorTurFer
Copy link
Member

JorTurFer commented Jun 27, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer JorTurFer merged commit b4299cc into kedacore:main Jun 27, 2022
@v-shenoy v-shenoy deleted the permission-segregation branch June 27, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-shenoy @tomkerkhove @zroubalik @JorTurFer