-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: scaleobject ready condition 'False/Unknow' to 'True' requeue #3097
Conversation
Signed-off-by: champly <[email protected]>
Signed-off-by: champly <[email protected]>
/run-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the changelog please?
Signed-off-by: champly <[email protected]>
ok, already added, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for the contribution! |
/run-e2e |
@champly do you think you can write some test for this scenario? |
Signed-off-by: champly <[email protected]>
ut have been added, and an |
Signed-off-by: champly <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, nice!
The only thing, why the changed perms on the Azure scaler files?
Signed-off-by: champly <[email protected]>
Oh, it should be edited automatically by the editor, it has been revert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/run-e2e |
Signed-off-by: champly [email protected]
Provide a description of what has been changed
Checklist
Fixes #3096
Relates to #