fix: use metricName from GetMetricsSpec in ScaledJobs instead of queueLength
#3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
|
/run-e2e external* |
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
changed the title
… always Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
|
/run-e2e external* |
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
|
/run-e2e external* |
JorTurFer
changed the title
queueLength
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
|
/run-e2e external* |
JorTurFer
changed the title
queueLengthqueueLength
|
/run-e2e |
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
|
/run-e2e |
|
/run-e2e |
tomkerkhove
reviewed
May 16, 2022
|
BTW, @zroubalik and/or @ahmelsayed , I'd like to have your review too |
Signed-off-by: Jorge Turrado <[email protected]>
zroubalik
reviewed
May 24, 2022
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
|
/run-e2e |
|
/run-e2e |
|
I'd say that the fail was because of race conditions due to running the "main" branch e2e tests at the same time. |
JorTurFer
changed the title
queueLengthqueueLength
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado [email protected]
After introducing the unique metric names using the prefix and the solution for external scaler, it fails in case of ScaledJobs because we use
queueLengthas a metric name in case of ScaledJob (ignoring the given name from the external scaler) and this metric doesn't have the prefix.This PR modifies the behaviour to use the metric spec given from GetMetricSpec instead of the hardcoded value, Using this approach all the code in the scaler that work for ScaledObject work for ScaledJob because now they follow the same behavior (from scaler internal pov).
I have added also an e2e with ScaledJob and external scaler to ensure the behaviour in the future and other small improvements
Checklist
Fixes # #3032