Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move account id to trigger auth on integration test for new relic #3027

Conversation

pragmaticivan
Copy link
Contributor

Moves account id to TriggerAuthentication for New Relic Integration Tests

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #2883

@pragmaticivan pragmaticivan requested a review from a team as a code owner May 9, 2022 20:28
@pragmaticivan pragmaticivan marked this pull request as draft May 9, 2022 20:29
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pragmaticivan it would be better if we create a separate test for this, instead of modifing the existing one. (The original approach is still valid imho).

@pragmaticivan
Copy link
Contributor Author

Makes sense @zroubalik I actually just wanted to run that test in the CI, was not sure if integrations were triggered in PRs

@JorTurFer
Copy link
Member

Makes sense @zroubalik I actually just wanted to run that test in the CI, was not sure if integrations were triggered in PRs

e2e test are not automatically triggered, but we can trigger them if you want

@JorTurFer
Copy link
Member

JorTurFer commented May 12, 2022

/run-e2e new-relic*
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented May 12, 2022

/run-e2e new-relic*
Update: You can check the progres here

@pragmaticivan
Copy link
Contributor Author

@JorTurFer I'm suspecting my latest change was correct but was not passed down (omitting account ID for new relic). will try to investigate why. Hopefully I can get integration tests running in my machine soon.

@JorTurFer
Copy link
Member

JorTurFer commented May 12, 2022

no no, the problem is in our cluster, 100% sure
We have recently merged some big changes from infra pov.
Let me check it

@JorTurFer
Copy link
Member

JorTurFer commented May 12, 2022

/run-e2e new-relic*
Update: You can check the progres here

@pragmaticivan
Copy link
Contributor Author

Thanks @JorTurFer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants