Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(newrelic): support New Relic account value from authentication resources #2898

Merged
merged 3 commits into from
Apr 12, 2022
Merged

feat(newrelic): support New Relic account value from authentication resources #2898

merged 3 commits into from
Apr 12, 2022

Conversation

pragmaticivan
Copy link
Contributor

@pragmaticivan pragmaticivan commented Apr 11, 2022 •
edited
Loading

This change introduces support for New Relic account as input from AuthConfig.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2883

@pragmaticivan pragmaticivan requested a review from a team as a code owner April 11, 2022 17:22
@pragmaticivan
Copy link
Contributor Author

Documentation is coming up soon.

@pragmaticivan pragmaticivan force-pushed the feature/2883-account-support-from-auth branch from ad6afd8 to 261ab33 Compare April 11, 2022 17:27
@pragmaticivan
Copy link
Contributor Author

Doc: kedacore/keda-docs#744

@pragmaticivan pragmaticivan mentioned this pull request Apr 11, 2022
Closed
JorTurFer
JorTurFer reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only small nit inline

CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Apr 11, 2022 •
edited by github-actions bot
Loading

/run-e2e new-relic*
Update: You can check the progres here

@pragmaticivan
Copy link
Contributor Author

Done @JorTurFer !

@pragmaticivan pragmaticivan force-pushed the feature/2883-account-support-from-auth branch from 987b7c7 to 26cb0a0 Compare April 12, 2022 01:22
JorTurFer
JorTurFer approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this improvement

zroubalik
zroubalik approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 9f0ee58 into kedacore:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pragmaticivan @JorTurFer @zroubalik