Rely on Datadog API to validate the query #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e datadog* |
JorTurFer
reviewed
Mar 17, 2022
arapulido
force-pushed
the
simplify_dd_query_parsing
branch
from
8b2cdc3
to
904f380
Compare
@JorTurFer thanks for the review! Updated the changelog |
|
/run-e2e datadog* |
JorTurFer
approved these changes
Mar 21, 2022
|
@arapulido |
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
arapulido
force-pushed
the
simplify_dd_query_parsing
branch
from
904f380
to
8bd04da
Compare
done! |
RamCohen
pushed a commit
to RamCohen/keda
that referenced
this pull request
Mar 23, 2022
Signed-off-by: Ram Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to validate all potential valid queries ahead of creating the scaledobject, rely on the Datadog API to do so and return the error returned by the API if that happens. Also, rely on the Datadog API to apply the default rollup time frame if one is not specified in the query.
This way, if there are any addition to the query language down the line, we won't need to change the scaler code, while simplifying it.
Checklist
Fixes #2761