Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datadog_scaler: handle mising { on dd query #2629

Merged
merged 2 commits into from
Feb 15, 2022
Merged

datadog_scaler: handle mising { on dd query #2629

merged 2 commits into from
Feb 15, 2022

Conversation

alileza
Copy link
Contributor

@alileza alileza commented Feb 14, 2022 •
edited
Loading

It's probably nice to handle the error gracefully rather than panic in case of unexpected datadog scaler query

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2625

@alileza alileza requested a review from a team as a code owner February 14, 2022 08:59
@alileza alileza force-pushed the handle_invalid_metrics_dd_scaler branch from 88f1ce7 to d1508f2 Compare February 14, 2022 09:04
@arapulido
Copy link
Contributor

Thanks for working on this! This looks good to me. 👍

tomkerkhove
tomkerkhove suggested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you update our changelog please?

@arapulido arapulido mentioned this pull request Feb 14, 2022
Closed
@alileza alileza force-pushed the handle_invalid_metrics_dd_scaler branch 3 times, most recently from 16a9b9a to fdbf7c1 Compare February 14, 2022 13:36
@alileza
Copy link
Contributor Author

alileza commented Feb 14, 2022

@tomkerkhove @zroubalik how does it look now?

zroubalik
zroubalik approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alileza !

@zroubalik
Copy link
Member

zroubalik commented Feb 14, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progres here

JorTurFer
JorTurFer approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvemen! ❤️

zroubalik
zroubalik reviewed Feb 14, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
datadog_scaler: handle mising { on dd query
3871c0d 
Signed-off-by: Ali Reza Yahya <[email protected]>

datadog_scaler: update change log

Signed-off-by: Ali Reza Yahya <[email protected]>

Update CHANGELOG.md

Co-authored-by: Zbynek Roubalik <[email protected]>
@alileza alileza force-pushed the handle_invalid_metrics_dd_scaler branch from 485c6f1 to 3871c0d Compare February 14, 2022 17:49
@zroubalik zroubalik merged commit 2b6c064 into kedacore:main Feb 15, 2022
@alileza alileza deleted the handle_invalid_metrics_dd_scaler branch February 15, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove requested changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataDog scaler makes KEDA operator crashing loop back
5 participants
@alileza @arapulido @zroubalik @tomkerkhove @JorTurFer