Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign main tag and add missing env during release workflow #2502

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 21, 2022

Signed-off-by: jorturfer [email protected]

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Related #2501

@JorTurFer JorTurFer requested a review from a team as a code owner January 21, 2022 17:30
Signed-off-by: jorturfer <[email protected]>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is extra whitespace

.github/workflows/release-build.yml Show resolved Hide resolved
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 21, 2022

I'm AFK, I'll update it in 40-50 min.

Signed-off-by: jorturfer <[email protected]>
@JorTurFer
Copy link
Member Author

These f******* whitespaces... 🤣 🤣 🤣
Solved

@zroubalik
Copy link
Member

These f******* whitespaces... 🤣 🤣 🤣 Solved

@JorTurFer btw you can enable pre-commit locally, so you catch these kind of issues before commiting the actual code.

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 21, 2022

I got it... but disabled because the tools are only installed inside the dev container, I should install them also in the host. Probably when my new computer arrives, I'll do something more reliable xD (usually I run it manually, but sometimes I forget it)

Anyway, thanks for the suggestion ❤️

@zroubalik zroubalik merged commit ba37a17 into kedacore:main Jan 21, 2022
@JorTurFer JorTurFer deleted the sign_main branch January 21, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants