Add AWS DynamoDB Scaler #2486

samueleresca · 2022-01-16T19:45:53Z

Signed-off-by: Samuele Resca [email protected]

Provide a description of what has been changed

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)
Tests have been added
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on Adding dynamodb scaler documentation keda-docs#680
Changelog has been updated

Fixes #2482

Signed-off-by: Samuele Resca <[email protected]>

…data. Signed-off-by: Samuele Resca <[email protected]>

Signed-off-by: Samuele Resca <[email protected]>

…-scaler

Signed-off-by: Samuele Resca <[email protected]>

tomkerkhove · 2022-02-22T05:55:09Z

Thanks for your PR! Would you mind opening and linking a PR for the docs please?

…-scaler

Signed-off-by: Samuele Resca <[email protected]>

zroubalik

Looking good, just a few minor nits on formatting.

Also a big ask is e2e testing. Do you think you can implement e2e tests for this scaler, similar to this https://github.com/kedacore/keda/tree/main/tests? We should have KEDA related AWS account soon CC @tomkerkhove

pkg/scalers/aws_dynamodb_scaler.go

Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Samuele Resca <[email protected]>

samueleresca · 2022-02-28T14:51:15Z

Looking good, just a few minor nits on formatting.

Also a big ask is e2e testing. Do you think you can implement e2e tests for this scaler, similar to this https://github.com/kedacore/keda/tree/main/tests? We should have KEDA related AWS account soon CC @tomkerkhove

I'm happy to implement the e2e tests for this. Should I do it in this PR?

zroubalik · 2022-02-28T14:56:26Z

Looking good, just a few minor nits on formatting.
Also a big ask is e2e testing. Do you think you can implement e2e tests for this scaler, similar to this https://github.com/kedacore/keda/tree/main/tests? We should have KEDA related AWS account soon CC @tomkerkhove

I'm happy to implement the e2e tests for this. Should I do it in this PR?

Yes please :)

pkg/scalers/aws_dynamodb_scaler.go

samueleresca · 2022-03-02T10:59:51Z

Looking good, just a few minor nits on formatting.
Also a big ask is e2e testing. Do you think you can implement e2e tests for this scaler, similar to this https://github.com/kedacore/keda/tree/main/tests? We should have KEDA related AWS account soon CC @tomkerkhove

I'm happy to implement the e2e tests for this. Should I do it in this PR?

Yes please :)

Regarding the e2e testing. I'm considering spanning up an instance using the following image for testing purposes: https://hub.docker.com/r/amazon/dynamodb-local. Until we don't have an AWS account. It should mimic the dynamodb on AWS, except for the fact that multiple regions are not supported

samueleresca · 2022-03-07T18:50:24Z

@zroubalik I updated the PR with the tests. I executed the E2E test locally with my personal subscription and looks good to me. Let me know if I can do something else.

zroubalik · 2022-03-11T11:13:48Z

@zroubalik I updated the PR with the tests. I executed the E2E test locally with my personal subscription and looks good to me. Let me know if I can do something else.

@JorTurFer @tomkerkhove how should we approach this? Do we know if there's any progress on the AWS account from CNCF?

zroubalik

Nit

tests/scalers/aws-dynamodb.test.ts

JorTurFer · 2022-03-11T12:18:54Z

@zroubalik I updated the PR with the tests. I executed the E2E test locally with my personal subscription and looks good to me. Let me know if I can do something else.

@JorTurFer @tomkerkhove how should we approach this? Do we know if there's any progress on the AWS account from CNCF?

If the e2e test is running, I'd keep it commented and I'd enable it when the account is ready. We already have other scalers without any e2e test, so I wouldn't block this PR.
Other option is using DynamoDB Local but I'm not sure if that development version could be enough for our e2e test case. Even if the local version is enough, I'd prefer using the real version, but this is an option

zroubalik · 2022-03-11T12:32:53Z

@zroubalik I updated the PR with the tests. I executed the E2E test locally with my personal subscription and looks good to me. Let me know if I can do something else.

@JorTurFer @tomkerkhove how should we approach this? Do we know if there's any progress on the AWS account from CNCF?

If the e2e test is running, I'd keep it commented and I'd enable it when the account is ready. We already have other scalers without any e2e test, so I wouldn't block this PR. Other option is using DynamoDB Local but I'm not sure if that development version could be enough for our e2e test case. Even if the local version is enough, I'd prefer using the real version, but this is an option

Yeah, let's disable e2e tests for now and enable once we have the account.

Signed-off-by: Samuele Resca <[email protected]>

…into dynamodb-scaler

tomkerkhove · 2022-03-12T09:15:58Z

No AWS account yet indeed. I will check

Signed-off-by: Samuele Resca <[email protected]>

CHANGELOG.md

tests/scalers/aws-dynamodb.test.ts

JorTurFer

You have done an awesome job! 🤟🤟🤟
Thanks for this contribution and all the effort, LGTM
Only 1 small nit inline (and please, rebase main because there is a conflict with one file)

pkg/scalers/aws_dynamodb_test.go

Signed-off-by: Samuele Resca <[email protected]>

JorTurFer

LGTM!
Thanks for the huge effort!

zroubalik

LGTM, thanks for the contribution! Great job.

CHANGELOG.md

Signed-off-by: Samuele Resca <[email protected]>

Signed-off-by: Samuele Resca <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Ram Cohen <[email protected]>

samueleresca added 4 commits January 20, 2022 09:41

Adding DynamoDB Scaler + Testing metadata parsing.

83ef62e

Signed-off-by: Samuele Resca <[email protected]>

Adding coverage GetMetrics methods.

9108d10

Signed-off-by: Samuele Resca <[email protected]>

Adding GetQueryMetrics tests.

a811770

Signed-off-by: Samuele Resca <[email protected]>

Updating configuration parsing.

e0c2bb6

Signed-off-by: Samuele Resca <[email protected]>

samueleresca force-pushed the dynamodb-scaler branch from 850bb97 to e0c2bb6 Compare January 20, 2022 09:43

samueleresca added 5 commits January 20, 2022 16:15

Updating Dynamo scaler: moving JSON parsing into parseAwsDynamoDBMeta…

63b0dcf

…data. Signed-off-by: Samuele Resca <[email protected]>

Cleaning code for linting rules + Adding IsActive test coverage.

cc1403e

Signed-off-by: Samuele Resca <[email protected]>

Updating code for linting rules.

6c0c7fd

Signed-off-by: Samuele Resca <[email protected]>

Updating with proper import formatting.

20f9934

Signed-off-by: Samuele Resca <[email protected]>

Merge branch 'main' of https://github.com/kedacore/keda into dynamodb…

a403f4b

…-scaler

samueleresca force-pushed the dynamodb-scaler branch from 39c1541 to 13398cd Compare February 21, 2022 12:32

Updating scalers.

bf0e96f

Signed-off-by: Samuele Resca <[email protected]>

samueleresca force-pushed the dynamodb-scaler branch from 13398cd to bf0e96f Compare February 21, 2022 12:34

samueleresca marked this pull request as ready for review February 21, 2022 13:12

samueleresca requested a review from a team as a code owner February 21, 2022 13:12

Merge branch 'main' of https://github.com/kedacore/keda into dynamodb…

a297157

…-scaler

samueleresca mentioned this pull request Feb 24, 2022

Adding dynamodb scaler documentation kedacore/keda-docs#680

Merged

1 task

Updating scaler removing metricName + Fix logging.

05a7f23

Signed-off-by: Samuele Resca <[email protected]>

tomkerkhove assigned zroubalik and JorTurFer Feb 28, 2022

zroubalik reviewed Feb 28, 2022

View reviewed changes

samueleresca and others added 3 commits February 28, 2022 14:46

Update pkg/scalers/aws_dynamodb_scaler.go

5b1c199

Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Samuele Resca <[email protected]>

Update pkg/scalers/aws_dynamodb_scaler.go

a0c681e

Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Samuele Resca <[email protected]>

Update pkg/scalers/aws_dynamodb_scaler.go

5357266

Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Samuele Resca <[email protected]>

samueleresca force-pushed the dynamodb-scaler branch from 408deb4 to b9bb6f3 Compare February 28, 2022 14:46

zroubalik reviewed Feb 28, 2022

View reviewed changes

pkg/scalers/aws_dynamodb_scaler.go Outdated Show resolved Hide resolved

zroubalik requested changes Mar 11, 2022

View reviewed changes

tests/scalers/aws-dynamodb.test.ts Outdated Show resolved Hide resolved

samueleresca added 3 commits March 11, 2022 19:16

Merge branch 'kedacore:main' into dynamodb-scaler

9592d3d

Using createNamespace helper.

30b977d

Signed-off-by: Samuele Resca <[email protected]>

Merge branch 'dynamodb-scaler' of https://github.com/samueleresca/keda …

90bb1e0

…into dynamodb-scaler

samueleresca requested a review from zroubalik March 11, 2022 19:23

samueleresca added 3 commits March 14, 2022 18:09

Merge branch 'main' into dynamodb-scaler

610b91c

Pull origin main.

f67456e

Signed-off-by: Samuele Resca <[email protected]>

Fix CHANGELOG.

6926736

zroubalik reviewed Mar 16, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

tests/scalers/aws-dynamodb.test.ts Show resolved Hide resolved

zroubalik changed the title ~~Add DynamoDB Scaler~~ Add AWS DynamoDB Scaler Mar 16, 2022

JorTurFer reviewed Mar 17, 2022

View reviewed changes

pkg/scalers/aws_dynamodb_test.go Outdated Show resolved Hide resolved

samueleresca added 4 commits March 17, 2022 21:05

Fixing CHANGELOG + Ignoring AWS e2e test.

d00b0f5

Signed-off-by: Samuele Resca <[email protected]>

Pulling main.

1e72ea2

Removing TODO.

f6ae0ee

Signed-off-by: Samuele Resca <[email protected]>

Adding newline to e2e test.

1539c69

Signed-off-by: Samuele Resca <[email protected]>

samueleresca requested a review from zroubalik March 17, 2022 21:43

JorTurFer approved these changes Mar 18, 2022

View reviewed changes

zroubalik approved these changes Mar 18, 2022

View reviewed changes

zroubalik requested changes Mar 18, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Updating CHANGELOG, removing unrelated entries.

6204e9b

Signed-off-by: Samuele Resca <[email protected]>

samueleresca force-pushed the dynamodb-scaler branch from 563f807 to 6204e9b Compare March 18, 2022 21:28

zroubalik enabled auto-merge (squash) March 22, 2022 09:02

zroubalik disabled auto-merge March 22, 2022 09:03

zroubalik merged commit 6cc380a into kedacore:main Mar 22, 2022

RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022

Add AWS DynamoDB Scaler (kedacore#2486)

54d1e58

Signed-off-by: Samuele Resca <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Ram Cohen <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AWS DynamoDB Scaler #2486

Add AWS DynamoDB Scaler #2486

samueleresca commented Jan 16, 2022 •

edited

Loading

tomkerkhove commented Feb 22, 2022

zroubalik left a comment •

edited

Loading

samueleresca commented Feb 28, 2022

zroubalik commented Feb 28, 2022

samueleresca commented Mar 2, 2022

samueleresca commented Mar 7, 2022 •

edited

Loading

zroubalik commented Mar 11, 2022

zroubalik left a comment

JorTurFer commented Mar 11, 2022

zroubalik commented Mar 11, 2022

tomkerkhove commented Mar 12, 2022

JorTurFer left a comment •

edited

Loading

JorTurFer left a comment

zroubalik left a comment

Add AWS DynamoDB Scaler #2486

Add AWS DynamoDB Scaler #2486

Conversation

samueleresca commented Jan 16, 2022 • edited Loading

Checklist

tomkerkhove commented Feb 22, 2022

zroubalik left a comment • edited Loading

Choose a reason for hiding this comment

samueleresca commented Feb 28, 2022

zroubalik commented Feb 28, 2022

samueleresca commented Mar 2, 2022

samueleresca commented Mar 7, 2022 • edited Loading

zroubalik commented Mar 11, 2022

zroubalik left a comment

Choose a reason for hiding this comment

JorTurFer commented Mar 11, 2022

zroubalik commented Mar 11, 2022

tomkerkhove commented Mar 12, 2022

JorTurFer left a comment • edited Loading

Choose a reason for hiding this comment

JorTurFer left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

samueleresca commented Jan 16, 2022 •

edited

Loading

zroubalik left a comment •

edited

Loading

samueleresca commented Mar 7, 2022 •

edited

Loading

JorTurFer left a comment •

edited

Loading