Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cron scaler to parse the cron with parser instead of searching for '-' #2038

Merged
merged 5 commits into from
Aug 20, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Aug 17, 2021

Signed-off-by: jorturfer [email protected]

This PR changes the method to validate the cron. Now the package parser is used to detect invalid expressions instead a custom method.

Checklist

Fixes #2034

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JorTurFer
Copy link
Member Author

I have just rebased main into this branch to add integrate the changes

@zroubalik zroubalik merged commit c370c05 into kedacore:main Aug 20, 2021
@JorTurFer JorTurFer deleted the cron_scaler branch August 20, 2021 10:07
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
… for '-' (kedacore#2038)

Signed-off-by: jorturfer <[email protected]>

Co-authored-by: Ahmed ElSayed <[email protected]>
Signed-off-by: nilayasiktoprak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron trigger does not support valid ranges
3 participants