Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding version metadata to be able to specify kafka broker version #1866

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

Dorn-
Copy link
Contributor

@Dorn- Dorn- commented Jun 5, 2021

Adding a metadata version to be able to set the user's kafka version. Right now, the value is hardcoded to 1.0.0 when calling the samara library. This commit will let the user specify which kafka version he is using only if it is supported by samara.
The PR updating the documentation will be submitted asap. To avoid any breaking changes, the default version is setted to 1.0.0 as before.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • [N/A] Changelog has been updated

See #1764
kedacore/keda-docs#464

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question regarding the default version, the rest is looking good!

pkg/scalers/kafka_scaler.go Outdated Show resolved Hide resolved
@Dorn- Dorn- force-pushed the feat/add-kafka-version-metadata branch from 80c06d7 to ae9cfeb Compare June 8, 2021 12:12
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit d11b1d6 into kedacore:main Jun 14, 2021
@zroubalik zroubalik added this to the v2.4.0 milestone Jul 14, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants