Add support for per-scaler override on the RabbitMQ vhost. #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to use a single user account for Keda without keeping separate connection strings for every vhost. Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
coderanger
force-pushed
the
rabbitmq-vhost
branch
from
f50dca5
to
02ff5ed
Compare
zroubalik
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
LGTM, thanks @coderanger! just waiting with the merge till docs PR is resolved
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
…1451) * Add support for per-scaler override on the RabbitMQ vhost. This makes it easier to use a single user account for Keda without keeping separate connection strings for every vhost. Signed-off-by: Noah Kantrowitz <[email protected]> * Update changelog. Signed-off-by: Noah Kantrowitz <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use a single user account for Keda without keeping separate connection strings for every vhost.
Adds a
vhostNamemetadata field to the rabbitmq scaler which overrides the vhost in the connection string coming from host or hostFromEnv.Checklist