TriggerAuthentication Secret is not reloaded when Secret changes

[dustin-decker]

Our deployment generates a random password for Redis (used as the trigger) during every deployment. The operator does not reload the credential when the Secret changes, so we see,

{"level":"error","ts":1579935742.1253839,"logger":"redis_scaler","msg":"error","error":"ERR invalid password","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128\ngithub.com/kedacore/keda/pkg/scalers.(*redisScaler).IsActive\n\tkeda/pkg/scalers/redis_scaler.go:96\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).handleScaleDeployment\n\tkeda/pkg/handler/scale_loop.go:119\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).handleScale\n\tkeda/pkg/handler/scale_loop.go:45\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).HandleScaleLoop\n\tkeda/pkg/handler/scale_loop.go:14"}

Expected Behavior

I expect the Secret resource to be watched and reload during create/update events.

Actual Behavior

The original Secret value is used and results in an invalid password error.

Steps to Reproduce the Problem

1. Deploy a ScaledObject + TriggerAuthentication that uses a Kubernetes Secret
2. Change the Secret's value
3. Observe invalid password failures

Specifications

• Version: v1.1.0
• Scaler(s): Redis (probably affects all TriggerAuthentication resources)

[tomkerkhove]

Nice find @dustin-decker, we should definately fix this! Should be fairly easy or not @ahmelsayed ?

[zroubalik]

Related to this #511

[zroubalik]

Could you please show me example configuraton of your TriggerAuthentication? To make it clear, the password change happens several times during the Deployment?

[zroubalik]

Should be fairly easy or not

Replying to your question @tomkerkhove 😄

TriggerAuthentication and relevant Secret should be updated and fetched by KEDA each pollingInterval, but if the Secret is updated in the meantime and scaling is happening, this problem occurs.

We will need to watch all TriggerAuthentication resources and referenced Secret and if there's any change, we will need to find all ScaledObjects that are using this TA and restart the scale loop logic. Because there's no direct reference between ScaledObject and TA.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed due to inactivity.