Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client certificate authentication for Metrics API scaler #1084

Closed
tomkerkhove opened this issue Sep 4, 2020 · 5 comments
Closed
Labels
auth feature All issues for new features that have been committed to good first issue Good for newcomers Hacktoberfest scaler-metrics-api All issues related to our Metrics API scaler security All issues related to security

Comments

@tomkerkhove
Copy link
Member

Use-Case

Support client certificate authentication for Metrics API scaler

Reference

#929

@tomkerkhove tomkerkhove added auth feature All issues for new features that have been committed to security All issues related to security scaler-metrics-api All issues related to our Metrics API scaler good first issue Good for newcomers Hacktoberfest labels Sep 4, 2020
@ddmendes
Copy link

ddmendes commented Oct 6, 2020

Hello! I'd like to work on this issue

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Oct 6, 2020

Thanks! But we already have a PR in the works by @aman-bansal, sorry.. (#1137)

@ddmendes
Copy link

ddmendes commented Oct 7, 2020

Oh, sorry, didn't notice, just checked there was no one assigned

@girishramnani
Copy link
Contributor

Seems like the related PR #1137 was merged, can this issue be closed?

@tomkerkhove
Copy link
Member Author

Jup, sorry about that!

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth feature All issues for new features that have been committed to good first issue Good for newcomers Hacktoberfest scaler-metrics-api All issues related to our Metrics API scaler security All issues related to security
Projects
None yet
Development

No branches or pull requests

3 participants