remove duplicate scaler error metric

Signed-off-by: Jan Wozniak <[email protected]>

pkg/metricscollector/prommetrics.go

@@ -41,15 +41,6 @@ var (
 		},
 		[]string{"version", "git_commit", "goversion", "goos", "goarch"},
 	)
-	scalerErrorsTotalDeprecated = prometheus.NewCounterVec(
-		prometheus.CounterOpts{
-			Namespace: DefaultPromMetricsNamespace,
-			Subsystem: "scaler",
-			Name:      "errors_total",
-			Help:      "DEPRECATED - will be removed in 2.16 - use a `sum(scaler_errors_total{scaler!=\"\"})` over all scalers",
-		},
-		[]string{},
-	)
 	scalerMetricsValue = prometheus.NewGaugeVec(
 		prometheus.GaugeOpts{
 			Namespace: DefaultPromMetricsNamespace,
@@ -223,7 +214,6 @@ type PromMetrics struct {
 }
 
 func NewPromMetrics() *PromMetrics {
-	metrics.Registry.MustRegister(scalerErrorsTotalDeprecated)
 	metrics.Registry.MustRegister(scalerMetricsValue)
 	metrics.Registry.MustRegister(scalerMetricsLatencyDeprecated)
 	metrics.Registry.MustRegister(scalerMetricsLatency)
@@ -300,7 +290,6 @@ func (p *PromMetrics) RecordScalerError(namespace string, scaledResource string,
 		scalerErrors.With(getLabels(namespace, scaledResource, scaler, triggerIndex, metric, isScaledObject)).Inc()
 		scalerErrorsDeprecated.With(getLabels(namespace, scaledResource, scaler, triggerIndex, metric, isScaledObject)).Inc()
 		p.RecordScaledObjectError(namespace, scaledResource, err)
-		scalerErrorsTotalDeprecated.With(prometheus.Labels{}).Inc()
 		return
 	}
 	// initialize metric with 0 if not already set