Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in cortex tenant parameter #952

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Fix typo in cortex tenant parameter #952

merged 3 commits into from
Sep 30, 2022

Conversation

djetelina
Copy link
Contributor

@djetelina djetelina commented Sep 30, 2022 •
edited
Loading

Fix typo in cortex tenant parameter and added information about Mimir

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Kinda Fixes #3024

@djetelina
Fix typo in cortex tenant parameter
e535e3d 
Also added information about Mimir

Signed-off-by: David Jetelina <[email protected]>
@djetelina djetelina requested a review from a team as a code owner September 30, 2022 11:05
@netlify
Copy link

netlify bot commented Sep 30, 2022 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 6e3bf2d
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/633717483e05650008988c1c
😎 Deploy Preview https://deploy-preview-952--keda.netlify.app/docs/2.9/scalers/prometheus
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JorTurFer
JorTurFer reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you update also the other versions which are wrong?
Those versions are:

  • 2.7
  • 2.8 (done)
  • 2.9

@djetelina
Update prometheus.md
315a22d 
Signed-off-by: David Jetelina <[email protected]>
@djetelina
Update prometheus.md
6e3bf2d 
Signed-off-by: David Jetelina <[email protected]>
@djetelina
Copy link
Contributor Author

Looking good, could you update also the other versions which are wrong?

That was fun doing this through GitHub web only :D Hopefully you're fine with my lazy commit messages 👼

JorTurFer
JorTurFer approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix ❤️

@JorTurFer JorTurFer merged commit 2458c5c into kedacore:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cortex header is missing
3 participants
@djetelina @tomkerkhove @JorTurFer