feat: Support regex usage in Azure Service Bus scaler. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4 tasks
tomkerkhove
reviewed
Aug 29, 2022
v-shenoy
force-pushed
the
feat/service-bus
branch
from
92525d0 to
1fe8dee
Compare
JorTurFer
reviewed
Aug 30, 2022
v-shenoy
force-pushed
the
feat/service-bus
branch
from
ecc4663 to
c0f6a6c
Compare
|
This PR looks a bit outdated with the code, or am I wrong? |
What do you mean? If you mean regarding the changes @JorTurFer is doing, yes. I will have to rebase and make changes once Jorge's commit with the new service bus package is merged. (Note - I am referring to the feature PR, not this docs PR) |
|
No, with regards to the changes for this feature as the code introduces these options: But the docs only list 2 of them. |
Oh no, |
tomkerkhove
approved these changes
Sep 12, 2022
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
v-shenoy
force-pushed
the
feat/service-bus
branch
from
40ecdec to
4052fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vighnesh Shenoy [email protected]
Provide a description of what has been changed
Checklist
Relates to kedacore/keda#3607