Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add oldest unacked message age metric documentation update for GCP Pub/Sub Scaler #579

Merged

Conversation

fira42073
Copy link
Contributor

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#2226

Signed-off-by: Friedrich Albert Kyuri <[email protected]>
@fira42073
Copy link
Contributor Author

@tomkerkhove tomkerkhove changed the title GCP Pub/Sub Scaler: add oldest unacked message age metric documentation update docs: add oldest unacked message age metric documentation update for GCP Pub/Sub Scaler Nov 16, 2021
@tomkerkhove
Copy link
Member

As per the issue, we should at least be backward compatible and deprecate the old field which is reflected in the docs

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to document the backward compatibility so cannot remove the old config, yet.

content/docs/2.5/scalers/gcp-pub-sub.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@zroubalik zroubalik merged commit b75567f into kedacore:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google pubsub custom metrics support
3 participants