Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for new selenium grid scaler #491

Merged
merged 4 commits into from
Jul 31, 2021

Conversation

prashanth-volvocars
Copy link
Contributor

Signed-off-by: prashanth [email protected]

Added documentation for selenium grid scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor nits though.

Could you move the documentation to content/docs/2.4/scalers/selenium-grid-scaler.md?
2.3 has already been released.

content/docs/2.3/scalers/selenium-grid-scaler.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/selenium-grid-scaler.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/selenium-grid-scaler.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/selenium-grid-scaler.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/selenium-grid-scaler.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/selenium-grid-scaler.md Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Sorry I missed this very minor nit during the previous review 🤦‍♂️

content/docs/2.4/scalers/selenium-grid-scaler.md Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the nice docs.

@prashanth-volvocars prashanth-volvocars force-pushed the seleniumgrid-scaler branch 2 times, most recently from f4797a5 to 04b7413 Compare July 27, 2021 12:45
@zroubalik zroubalik merged commit b29f45e into kedacore:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants