-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for new selenium grid scaler #491
Added documentation for new selenium grid scaler #491
Conversation
Signed-off-by: prashanth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, minor nits though.
Could you move the documentation to content/docs/2.4/scalers/selenium-grid-scaler.md
?
2.3 has already been released.
b913476
to
f56bc98
Compare
…ame parameter Signed-off-by: prashanth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Sorry I missed this very minor nit during the previous review 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the nice docs.
f4797a5
to
04b7413
Compare
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: prashanth <[email protected]>
Signed-off-by: prashanth <[email protected]>
Signed-off-by: prashanth [email protected]
Added documentation for selenium grid scaler
Checklist