influxdb: document which paramters may be used from triggerauthentication #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acobaugh
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
tomkerkhove
suggested changes
Jun 26, 2021
|
Is there an example scaler that's formatted the way we want? I'm having a hard time understanding what needs to be changed. |
tomkerkhove
reviewed
Jul 1, 2021
|
I have added some more suggestions which hopefully help but https://github.com/kedacore/keda-docs/blob/master/content/docs/2.4/scalers/azure-service-bus.md is typically the one I refer to |
|
@acobaugh do you think you'll have a time to finish this PR? |
acobaugh
force-pushed
the
influxdb-update
branch
from
18758fb
to
aaae19c
Compare
|
I think this is good to my eye, but could use a second look from someone since we've changed a bunch of formatting and wording since the PR was originally opened. Thanks! |
|
Thank you! Can you have a look at #472 (comment) please? |
…tion and provide an example Signed-off-by: Andy Cobaugh <[email protected]>
acobaugh
force-pushed
the
influxdb-update
branch
from
aaae19c
to
5b37f4c
Compare
|
I think this should be good now. |
|
Hi @acobaugh , |
|
Closing due to no response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the influxdb scaler docs for 2.4 to state which parameters can be specified from (cluster)triggerauthentication, as a followup to kedacore/keda#1904
Checklist