Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update postgres scaler docs with metricName #313

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

ycabrer
Copy link
Contributor

@ycabrer ycabrer commented Nov 25, 2020

Signed-off-by: ycabrer [email protected]

Documentation update for PR kedacore/keda#1381

content/docs/1.4/scalers/postgresql.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

could you please target this against 2.1 and not 1.4, eg content/docs/2.1/scalers/

@ycabrer
Copy link
Contributor Author

ycabrer commented Nov 30, 2020

Whoops, that would help. Yes.

@ycabrer
Copy link
Contributor Author

ycabrer commented Nov 30, 2020

@zroubalik I hope that's better. Let me know if it needs anything else!

Thank you!

@ycabrer ycabrer requested a review from zroubalik November 30, 2020 20:43
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor nit only!

content/docs/2.1/scalers/postgresql.md Outdated Show resolved Hide resolved
Signed-off-by: ycabrer <[email protected]>
@ycabrer ycabrer requested a review from zroubalik December 2, 2020 04:29
@tomkerkhove tomkerkhove merged commit 589c9b5 into kedacore:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants