Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc link reference in setupscaler.md #1502

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

applike-ss
Copy link
Contributor

@applike-ss applike-ss commented Nov 20, 2024

Two links contained specific keda versions, one of them even not being the latest one.

I removed the version numbers, as the website redirects to the latest docs in this case.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@applike-ss applike-ss requested a review from a team as a code owner November 20, 2024 15:15
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 790261a
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/67442ae48217980008da8d6f
😎 Deploy Preview https://deploy-preview-1502--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Thank you for fixing this, can you also please address this under 2.15 version of the docs?

- Follow the [KEDA installation guide](https://keda.sh/docs/2.14/deploy/) carefully, including any prerequisites specific to your Kubernetes setup.

1. Visit the [KEDA Scalers documentation](https://keda.sh/docs/2.14/scalers/) and browse through the list of available scalers.

content/docs/2.16/setupscaler.md Outdated Show resolved Hide resolved
content/docs/2.16/setupscaler.md Outdated Show resolved Hide resolved
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit aa42baf into kedacore:main Nov 26, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants