Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cassandra tls #1390

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

rxg8255
Copy link
Contributor

@rxg8255 rxg8255 commented May 14, 2024

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes: kedacore/keda#5802

@rxg8255 rxg8255 requested a review from a team as a code owner May 14, 2024 23:14
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented May 14, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit d3d4777
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/667df6689bd7f0000829fc2d
😎 Deploy Preview https://deploy-preview-1390--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would you mind linking the feature PR please?

We can only merge if that one was merged

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rxg8255 I have already merged the feature PR and realised that this docs PR targets 2.14, could you please move the changes to 2.15 and make sure they are up to date with the merged feature? Thanks!

@rxg8255 rxg8255 requested review from zroubalik and tomkerkhove June 27, 2024 15:19
@rxg8255 rxg8255 force-pushed the feature-cassandra-tls-v3 branch from b3e002f to 9c9147f Compare June 27, 2024 16:11
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik
Copy link
Member

@rxg8255 could you please include only commit with your changes? (rebase)

@rxg8255 rxg8255 force-pushed the feature-cassandra-tls-v3 branch from eef0f99 to 640ca7c Compare June 27, 2024 20:16
@rxg8255 rxg8255 force-pushed the feature-cassandra-tls-v3 branch 2 times, most recently from 29fca26 to 8a4ab2b Compare June 27, 2024 23:30
@rxg8255
Copy link
Contributor Author

rxg8255 commented Jun 28, 2024

@rxg8255 could you please include only commit with your changes? (rebase)

Merged all commits to 1

@zroubalik zroubalik merged commit a19d8f9 into kedacore:main Jul 1, 2024
8 checks passed
SpiritZhou pushed a commit to SpiritZhou/keda-docs that referenced this pull request Jul 11, 2024
Signed-off-by: Ranjith Gopal <[email protected]>
Co-authored-by: Ranjith Gopal <[email protected]>
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Aug 5, 2024
Signed-off-by: Ranjith Gopal <[email protected]>
Co-authored-by: Ranjith Gopal <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cassandra TLS auth
3 participants