Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Kafka MSK authentication parameters #1381

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Document Kafka MSK authentication parameters #1381

merged 1 commit into from
Apr 25, 2024

Conversation

adrien-f
Copy link
Contributor

Documents kedacore/keda#5692

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@adrien-f adrien-f requested a review from a team as a code owner April 25, 2024 08:20
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 7089776
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/662a125476d0c50008b156cd
😎 Deploy Preview https://deploy-preview-1381--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adrien-f adrien-f mentioned this pull request Apr 25, 2024
Merged
7 tasks
zroubalik
zroubalik approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 008b032 into kedacore:main Apr 25, 2024
9 checks passed
@zroubalik zroubalik mentioned this pull request Apr 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien-f @zroubalik