Add adapter metrics service flags to 2.14 docs #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
3 tasks
aliaqel-stripe
changed the title
JorTurFer
reviewed
Feb 6, 2024
content/docs/2.14/operate/cluster.md
Outdated
| | Adapter Flag | Default Value | Description | | ||
| | ----------------------------------- | ------------------------------------------------- | ---------------------------------------------- | | ||
| | metrics-service-address | keda-operator.keda.svc.cluster.local:9666 | The address of the GRPC Metrics Service Server | | ||
| | metrics-service-grpc-authority | "" | Host Authority override for the Metrics Service if the Host Authority is not the same as the address used for the GRPC Metrics Service Server. | |
There was a problem hiding this comment.
Could we add a note explaining where this can be useful? a brief description of your use case would be nice (from top level, but just for giving a real world case to improve the understanding of the parameter)
There was a problem hiding this comment.
let me know what you think of the updated comment
aliaqel-stripe
force-pushed
the
aliaqel/add-adapter-flags-to-docs
branch
from
5268971 to
f34f712
Compare
zroubalik
reviewed
Feb 12, 2024
Signed-off-by: Ali Aqel <[email protected]>
aliaqel-stripe
force-pushed
the
aliaqel/add-adapter-flags-to-docs
branch
from
4a7f056 to
571f9c3
Compare
zroubalik
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add section in the cluster docs in version 2.13 to describe the metrics-service flags (including the one added by kedacore/keda#5450
Checklist
Fixes #kedacore/keda#5449