Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(prometheus): remove deprecated metricName from examples #1292

Merged
merged 1 commit into from
Jan 16, 2024
Merged

docs(prometheus): remove deprecated metricName from examples #1292

merged 1 commit into from
Jan 16, 2024

Conversation

wrdls
Copy link
Contributor

@wrdls wrdls commented Jan 16, 2024 •
edited
Loading

metricName was removed in the 2.12 release but was still present in the examples.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@wrdls wrdls requested a review from a team as a code owner January 16, 2024 09:47
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 014a80e
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65a650bf64401d0008de331d
😎 Deploy Preview https://deploy-preview-1292--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

tomkerkhove
tomkerkhove approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks!

@tomkerkhove tomkerkhove merged commit f4500db into kedacore:main Jan 16, 2024
9 checks passed
@tomkerkhove tomkerkhove mentioned this pull request Jan 16, 2024
Merged
1 task
@wrdls wrdls deleted the patch-1 branch January 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrdls @tomkerkhove