Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for spec.hashiCorpVault.credential.seviceAccount default value #1278

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

dttung2905
Copy link
Contributor

Hi team,

This PR incorporates changes from the PR kedacore/keda#5180.

Let me know if we need to retrospectively change documentation for previous release ( < 2.13 ) as well

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@dttung2905 dttung2905 requested a review from a team as a code owner December 14, 2023 15:59
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0d92c2f
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/658015868f0c1d0008015f4a
😎 Deploy Preview https://deploy-preview-1278--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/docs/2.13/concepts/authentication.md Outdated Show resolved Hide resolved
@tomkerkhove tomkerkhove merged commit 7bd27b2 into kedacore:main Dec 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants