Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Admission Webhooks Doc #1181

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Update Admission Webhooks Doc #1181

merged 5 commits into from
Aug 29, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Jul 10, 2023 •
edited by tomkerkhove
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#4528

Update Doc
8b6c920 
Signed-off-by: Zhenghan Zhou <[email protected]>
@SpiritZhou SpiritZhou requested a review from a team as a code owner July 10, 2023 08:24
@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 2981a2e
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/64ede253ae889f0008702d3d
😎 Deploy Preview https://deploy-preview-1181--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@SpiritZhou SpiritZhou mentioned this pull request Jul 10, 2023
Merged
5 tasks
@tomkerkhove
Copy link
Member

Waiting for feature to be merged

@tomkerkhove
Copy link
Member

Linked issue

Update admission-webhooks.md
cbe4879 
Signed-off-by: Zhenghan Zhou <[email protected]>
@tomkerkhove tomkerkhove enabled auto-merge (squash) August 29, 2023 12:19
@tomkerkhove tomkerkhove merged commit 0b3a414 into kedacore:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiritZhou @tomkerkhove @JorTurFer