fix: Create copy of backoff struct #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backoff is created in `interceptor/main.go` and `.Step()` is a pointer receiver, so `.Step()` will mutate the underling number of `.Steps` within the struct. When you have 0 replicas, the default 500ms timeout of the Dial is hit which basically guarantees that you will end up calling `.Step()`. The value inside the the struct will never be reset, and so every single time you're scaling from 0, you're guaranteed to reduce the number of `.Steps` by 1 and this will never reset until the application itself has been restarted. This change makes sure that every time we execute `DialContextWithRetry`, we start with a fresh `backoff` which will start the `.Steps` at 5 since it's a clone of the original `backoff`. This `backoff` is available in the context of the function returned by `DialContextWithRetry`, which will be the one that gets decremented, and then will be garbage collected and we get a brand new 5 steps the next time we execute `DialContextWithRetry`. Closes kedacore#586 Signed-off-by: Aaron Batilo <[email protected]>
JorTurFer
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backoff is created in
interceptor/main.goand.Step()is a pointer receiver, so.Step()will mutate the underling number of.Stepswithin the struct. When you have 0 replicas, the default 500ms timeout of the Dial is hit which basically guarantees that you will end up calling.Step(). The value inside the the struct will never be reset, and so every single time you're scaling from 0, you're guaranteed to reduce the number of.Stepsby 1 and this will never reset until the application itself has been restarted.This change makes sure that every time we execute
DialContextWithRetry, we start with a freshbackoffwhich will start the.Stepsat 5 since it's a clone of the originalbackoff. Thisbackoffis available in the context of the function returned byDialContextWithRetry, which will be the one that gets decremented, and then will be garbage collected and we get a brand new 5 steps the next time we executeDialContextWithRetry.Fixes #586
Signed-off-by: Aaron Batilo [email protected]