Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use make for scripting unifying the KEDA tools #564

Merged
merged 5 commits into from
Jan 13, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 5, 2023

Signed-off-by: Jorge Turrado [email protected]

As we use make for keda, let's standardize the tooling across repositories.
This PR also moves the e2e test from only main branch to every PR (and also every push to main) due to now it's possible having the manifests close to the code.
Any information related with mage has been updated and any dependency has been replaced by other tools

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer marked this pull request as ready for review January 6, 2023 17:29
@JorTurFer JorTurFer changed the title WIP - feat: use make for scripting feat: use make for scripting unifying the KEDA tools Jan 6, 2023
.github/workflows/build_release.yml Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
config/interceptor/interceptor.yaml Outdated Show resolved Hide resolved
docs/developing.md Outdated Show resolved Hide resolved
docs/developing.md Outdated Show resolved Hide resolved
interceptor/main.go Outdated Show resolved Hide resolved
operator/main.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@tomkerkhove
Copy link
Member

Nice job!

Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
@JorTurFer JorTurFer requested a review from a team as a code owner January 9, 2023 07:22
JorTurFer and others added 3 commits January 9, 2023 08:22
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer merged commit 50e4958 into kedacore:main Jan 13, 2023
@JorTurFer JorTurFer deleted the use-make branch January 13, 2023 15:20
@JorTurFer JorTurFer added this to the v0.4.0 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants