support portName in HTTPScaledObject service scaleTargetRef #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wozniakjan
force-pushed
the
allow_portName_in_httpso_service
branch
2 times, most recently
from
c986503
to
bcd5e45
Compare
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
force-pushed
the
allow_portName_in_httpso_service
branch
from
bcd5e45
to
9d1e194
Compare
jkremser
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
👍 maybe they should be mutually exclusive, can be done using x-kubernetes-validations. If not, we can check that at least one of them is set, also by these X rules. Something like:
// +kubebuilder:validation:XValidation:rule=(has(self.PortName) || has(self.Port))
zroubalik
reviewed
Oct 23, 2024
This is neat! I will explore it a bit more and definitely find a place for this in my toolset :)
right, I knew I forgot something, will followup shortly :) |
Co-authored-by: Jirka Kremser <[email protected]> Signed-off-by: Jan Wozniak <[email protected]>
Signed-off-by: Jan Wozniak <[email protected]>
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
force-pushed
the
allow_portName_in_httpso_service
branch
from
bb59ad6
to
acfe4bd
Compare
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
force-pushed
the
allow_portName_in_httpso_service
branch
3 times, most recently
from
17de409
to
8b66f00
Compare
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
force-pushed
the
allow_portName_in_httpso_service
branch
from
8b66f00
to
a98dab2
Compare
wozniakjan
commented
Oct 24, 2024
Comment on lines
+15
to
+22
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - services | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch |
There was a problem hiding this comment.
highlighting that newly services RBAC will be necessary for the interceptor
Signed-off-by: Jan Wozniak <[email protected]>
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HTTPScaledObjectallowed setting only numericalportvalue for the scaled services. For improved UX, it also allows to setnamedPortto match common conventions in the kubernetes API regardingServicesand ports.Checklist