Change cluster role binding name for metrics adapter #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <[email protected]>
tomkerkhove
requested review from
ahmelsayed,
jeffhollan and
zroubalik
as code owners
|
@zroubalik If you agree on this I'll send a PR to kedacore/keda as well. |
|
We talked about this with @tbickford and it shouldn't be needed to do this change. That's a bug in Helm if I am not mistaken. |
|
It's not a bug but a new validation rule they've added. We can use a specific Helm version but will only be a workaround AFAIK. I figured KEDA 2.0 was the right time to align this. |
|
So, what do we do with this one? Do we include it in 2.0 or abandon the PR? |
|
@tomkerkhove let's double check on standup and with @tbickford |
ahmelsayed
approved these changes
Oct 26, 2020
|
@zroubalik We forgot to check but let's not inclulde it for 2.0 |
|
@tomkerkhove agree, we can reiterate later |
5 tasks
wozniakjan
added a commit
to wozniakjan/keda-charts
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
added a commit
to wozniakjan/keda-charts
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
added a commit
to wozniakjan/keda-charts
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
added a commit
to wozniakjan/keda-charts
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
added a commit
to wozniakjan/keda-charts
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Jan Wozniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Kerkhove [email protected]
Change cluster role binding name for metrics adapter to comply with Helm naming convention.