Output Mapping - Support for treat values as null flag #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikZigo
changed the title
ErikZigo
commented
Nov 21, 2024
| @@ -2276,4 +2469,47 @@ private function getTableIdFromJobDetail(array $jobData): string | |||
|
|
|||
| self::fail(sprintf('Cannot detect tableId from %s job', $operationName)); | |||
| } | |||
|
|
|||
| private function findTableCreateJobForTable(string $tableId, array $jobsIds): ?array | |||
There was a problem hiding this comment.
JobIds jsou v poradi, v jakem Finder nasel soubory na disku. Ted tam neni sort a lokalne a na CI to jde v jinem poradi. Proto to musim vyhledavat.
|
Sakra mám tam renonc. Ono to bude fungovat jen pro tabulky, které byly založené už dříve. U těch, které založil OM před samotným importem ne. To musím upravit tu podmínku a testy. Náhodou jsem si toho všiml v docker-bundle :) |
ErikZigo
force-pushed
the
erik-PST-1468
branch
from
0450400
to
57636ea
Compare
ErikZigo
commented
Nov 22, 2024
| $source->getDestination()->getTableName(), | ||
| )); | ||
| } | ||
| $loadOptions['treatValuesAsNull'] = $treatValuesAsNullConfiguration; |
There was a problem hiding this comment.
Posila se vzdy, i pri zalozeni tabulky z CSV. To ted nicemu nevadi, protoze ten endpoint dovoluje extraKeys.
|
@ondrajodas uz je to ready |
ErikZigo
commented
Nov 23, 2024
| @@ -49,7 +49,6 @@ | |||
| </testsuite> | |||
| <testsuite name="new-native-types"> | |||
| <file>tests/Writer/TableDefinitionV2Test.php</file> | |||
| <file>tests/TableLoaderTest.php</file> | |||
There was a problem hiding this comment.
Neni potreba, protoze to co to testovalo jsem presunul do TableCreator a ma to vlastni testy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://keboola.atlassian.net/browse/PST-1468