Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PST-1710: Add keboola/encryption-api-php-client #261

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

PST-1710: Add keboola/encryption-api-php-client #261

wants to merge 17 commits into from

Conversation

romantmb
Copy link
Contributor

@romantmb romantmb commented May 14, 2024 •
edited
Loading

@romantmb romantmb marked this pull request as ready for review May 16, 2024 11:17
romantmb
romantmb commented May 16, 2024
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
@romantmb
create libs/encryption-api-client, copy sources & tests from former repo
5d67e4b
@romantmb
add encryption-api-client into docker-compose & azure pipelines
d180a9e
@romantmb
add missing tests/bootstrap.php, temp. disable encryption-api-client …
fa94308 
…publishing
@romantmb
add missing tests_encryptionApiClient dep. in azure pipelines testsRe…
4031e8a 
…sults stage
@romantmb
add missing "infection/infection" in encryption-api-client/composer.json
0e21f1a
@romantmb
phpstan: replace deprecated checkMissingIterableValueType param with …
04edacc 
…`identifier: missingType.iterableValue` in ignoreErrors
@romantmb
phpcs: exclude trailing comma in func calls
aebae13
@romantmb
extend tests
75a1fa3
@romantmb
decrease infection MSI to 70
32aa74a
@romantmb
run tests for both PHP 7.4 and 8.2
5bf1b45
@romantmb
change dir before composer run in tests template
6de70f6
@romantmb
add alt. version of infection/infection that supports PHP 7.4
7c99a7f
@romantmb
make phpstan.neon compatible with both phpstan 9.5 (PHP 7.4) 9.6 (PHP…
40865b0 
… 8.2)
@romantmb
put xdebug.mode=coverage into xdebug.ini in 7.4 tests pipeline
f75d42c
@romantmb
typo fix
b671b68
pepamartinec
pepamartinec reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@pepamartinec pepamartinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verim, ze code je 1:1 zkopirovany, kontroloval jsem teda jen configuraci CI. Tam jsem si niceho podezrelyho nevsiml, ale poprosil bych te to tam seradit podle abecedy, at v tom mame poradek.

azure-pipelines.tags.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
pepamartinec
pepamartinec approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@pepamartinec pepamartinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepamartinec pepamartinec pepamartinec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romantmb @pepamartinec